fix(appellate): Tweaks ACMSPageHandler to handle firefox load - #422
Merged
Conversation
ERosendo
force-pushed
the
refactor-updates-logic-to-create-acms-observer
branch
from
February 1, 2026 04:36
1f91f00 to
758384c
Compare
ERosendo
marked this pull request as ready for review
February 1, 2026 05:07
mlissner
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ACMS page observer to handle Firefox page load timing and make sure observer is active for HTMX updates.
The existing
ACMSPageHandlerlogic had a conditional that would skip observer creation ifindexContentorfullDocketContentelements were already present on the page. This behavior worked in Chrome, where the extension typically loads before HTMX incrementally adds content, but broke in Firefox, where the page often finishes loading before the extension runs.In Firefox this resulted in:
handleAcmsDocket()would run but no observer was createdkey changes:
handleAcmsDocket()call for already-loaded contentACMSPageHandleris called multiple times